Proposition for extension of class Arguments #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to generate javascript like: this.random.apply(this, arguments); or $.Widget.prototype._setOptions.apply(this, arguments); The property name "List" is questionable. Other options would be "Self", "This", "Instance". Do you have suggestion for better name?
|
The Arguments functionality has been a bit hacky since I added it. This is what I should have done ... added a non-static Arguments class (with length and a read-only indexer), and a Script.Arguments property. I'll need to go back and revisit this... can't remember what was the issue. In the interim, I'd suggest naming this to "Current" as that more accurately conveys the semantics IMO, and I'll accept the pull request. |
nikhilk
added a commit
that referenced
this pull request
Jun 30, 2012
Proposition for extension of class Arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to generate javascript like:
this.random.apply(this, arguments);
or
$.Widget.prototype._setOptions.apply(this, arguments);
The property name "List" is questionable. Other name choices would be "Self" or "This". Do you have suggestion for better name?